feat(View): forward browser events #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Are you sure you are not running into some issue because of the debounce and the fact that react recycle events? |
Contributor
Author
|
React doesn't recycle events anymore starting from React 17, but even in older versions it would be enough to call I tested this extensively for a day and everything is working as intended, it allowed us to dramatically improve the performance of our custom-made widgets 🥳 |
Collaborator
|
Can you add a vtk.js dependency in the example to see if that fix the ci? See #32. Thanks |
Collaborator
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having access to the browser events is useful if you need to perform logic with the mouse position, modifier keys, etc.
This change should preserve backwards compatibility with the existing interface by adding a second argument to the event callbacks.