fix(View): don’t throw cannot get getViewMatrix of undefined error when showCubeAxes is set to false
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Aug 10, 2021
src/core/View.js
Outdated
| this.resetCamera = this.resetCamera.bind(this); | ||
| const bbox = vtkBoundingBox.newInstance({ bounds: [0, 0, 0, 0, 0, 0] }); | ||
| this.updateCubeBounds = () => { | ||
| if (this.props.showCubeAxes !== true) return; |
Collaborator
There was a problem hiding this comment.
Should we do that instead?
if (!this.props.showCubeAxes) {
return;
}
Contributor
Author
There was a problem hiding this comment.
Matter of preferences I suppose, your suggestion will cast any thruty value to false, while mine will explicitly check for a true boolean. I updated my PR to use your version though.
Collaborator
There was a problem hiding this comment.
Thanks. I think that I use the loose test everywhere else so just to be on the safe side I rather let it be anything. Thanks for the edit.
…en shoeCubeAxes is set to false
FezVrasta
force-pushed
the
fix/getviewmatrix-of-undefined
branch
from
bb3c6dc to
c6d7ae6
Compare
Collaborator
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switch between different mouse adaptors programmatically (directly interacting with the
styleandviewinstances) we often get the error:This happens on the CubeAxesActor instance, and only happens if
showCubeAxesprop is not set totrue.This change prevents the error from happening.