feat(Rendering): Introduce Geometry2DRepresentation #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does react-vtk-js have some testing framework we could use here? |
Collaborator
|
unfortunately not. Just manual examples to test |
jourdain
reviewed
Dec 7, 2021
jourdain
approved these changes
Dec 7, 2021
Collaborator
jourdain
left a comment
jourdain
left a comment
There was a problem hiding this comment.
Seems reasonable. Glancing through the code seems fine.
Collaborator
Author
|
@jourdain Could you please merge this one too? |
Collaborator
|
@sankhesh the pipeline is broken now... |
Collaborator
Author
|
@jourdain Thanks for letting me know. Fixing now. |
Collaborator
Author
|
Fixed in #49 |
Collaborator
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Kitware/vtk-js#2179