Improve usage examples#54
Merged
floryst merged 1 commit intoKitware:masterfrom Mar 7, 2022
Merged
Conversation
jourdain
approved these changes
Mar 2, 2022
Collaborator
jourdain
left a comment
jourdain
left a comment
There was a problem hiding this comment.
LGTM but I haven't tested it. Thanks for providing such PR to improve usage testing/experience.
Contributor
|
I did a quick passthrough, and it looks reasonable to me. Off the top of my head, the differences in the PolyDataViewer seem to be related to whichever representation configuration is set. I'm good to merge this and figure that out later, since it's not that much of a critical thing in my opinion. |
Collaborator
|
I let you handle the merge @floryst since you are playing with that project more lately. ;-) |
Collaborator
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm debugging some things with the lib and wanted to use the examples for this, but building or using it for dev (
npm run devinsideusage) was taking so much time, so I made a few changes:usagenpm run devon root folder puts rollup on watch mode, this allows to make changes and see it instantly on the usage examples.Only difference I see at first glance from current examples is with the
Geometry/PolyDataViewer, but not sure if current one is fine or new one is how it should look. If new one is wrong and you like this change I can try to find what is happening.Note: This is not a must have change, but it's been pretty helpful to me while testing the library with the examples.
Current:
New:
