Skip to content

Conversation

@sankhesh
Copy link
Collaborator

@sankhesh sankhesh commented Apr 8, 2022

No description provided.

@sankhesh
Copy link
Collaborator Author

sankhesh commented Apr 8, 2022

@jourdain

@jourdain
Copy link
Collaborator

jourdain commented Apr 8, 2022

That won't trigger a new release which might be fine for your use case. Just let me know if I should merge or if you want to change the commit type?

@sankhesh
Copy link
Collaborator Author

sankhesh commented Apr 8, 2022

Good point @jourdain. Will this trigger a minor/patch release or no release at all? What do you suggest for changes that update core dependencies like vtk-js?

In my case, a minor release would be fine as it might still enable the application to pull latest react-vtk-js.

@jourdain
Copy link
Collaborator

jourdain commented Apr 8, 2022

minor release => fix(vtk-js): Update to xx.xx.x

@sankhesh
Copy link
Collaborator Author

@jourdain Could you please merge this?

@jourdain jourdain merged commit aee6ace into Kitware:master Apr 11, 2022
@jourdain
Copy link
Collaborator

🎉 This PR is included in version 1.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants