Skip to content

Conversation

@floryst
Copy link
Contributor

@floryst floryst commented May 4, 2022

Adds support for multiple views as renderers, rather than each View being a single render window.

Also adds an example to test/play with.

floryst added 3 commits May 4, 2022 16:37
Changes the View export to be multi-view aware. The new MultiViewRoot
component will convert View components into using renderers, rather than
individual render windows.
@floryst floryst requested a review from jourdain May 4, 2022 20:44
@floryst
Copy link
Contributor Author

floryst commented May 4, 2022

A video demonstration:

480.Screen.Recording.2022-05-04.at.4.44.56.PM.mov

Running the example usage will give a better sense of the functionality.

Copy link
Collaborator

@jourdain jourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jourdain
Copy link
Collaborator

jourdain commented May 4, 2022

Pretty cool what you've done!

floryst added 4 commits May 5, 2022 10:19
This allows users to change the view's style if they so please.
The current renderer should only be set if the container exists (which
implies that the renderer is not deleted.)
@floryst floryst merged commit f6e5f27 into master May 5, 2022
@floryst floryst deleted the multi-view-root branch May 5, 2022 19:31
@jourdain
Copy link
Collaborator

jourdain commented May 5, 2022

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants