Skip to content

fix gh pages publish#63

Merged
floryst merged 2 commits intoKitware:masterfrom
osiux:fix/gh-pages
May 19, 2022
Merged

fix gh pages publish#63
floryst merged 2 commits intoKitware:masterfrom
osiux:fix/gh-pages

Conversation

@osiux
Copy link
Copy Markdown
Contributor

@osiux osiux commented May 19, 2022

fix for #62

@osiux osiux mentioned this pull request May 19, 2022
@floryst
Copy link
Copy Markdown
Contributor

floryst commented May 19, 2022

Turns out my repro issue is that CI is using node 12 (which fails), but I'm using node 16 (which works). Since node 12 is EOL, I would prefer if this change instead bumps the node version from 12 to 16.

@osiux
Copy link
Copy Markdown
Contributor Author

osiux commented May 19, 2022

You are totally right, updating node version instead!

@floryst floryst merged commit 3481960 into Kitware:master May 19, 2022
github-actions Bot pushed a commit that referenced this pull request May 19, 2022
github-actions Bot pushed a commit to osiux/react-vtk-js that referenced this pull request May 19, 2022
@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Jun 7, 2022

🎉 This PR is included in version 1.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants