fix(XMLWriter): Bunp vtk.js version to fix crash when using XMLWriter#92
Merged
floryst merged 1 commit intoKitware:masterfrom Dec 16, 2022
Merged
fix(XMLWriter): Bunp vtk.js version to fix crash when using XMLWriter#92floryst merged 1 commit intoKitware:masterfrom
floryst merged 1 commit intoKitware:masterfrom
Conversation
sankhesh
reviewed
Dec 16, 2022
Collaborator
sankhesh
left a comment
sankhesh
left a comment
There was a problem hiding this comment.
Are the changes in the package-lock file intentional? They seem to be removing the original dependencies and bringing in different ones.
Contributor
Author
|
Yes, I just followed the procedure as in 7fc434c to update vtk.js. I tested against the latest versions of node and npm and didn't find any issues. |
Contributor
|
I think this might be due to react-vtk-js still inadvertently bundling parts of vtk.js. In any case, the changes look fine for now, but there's still an underlying issue. |
github-actions Bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
fix(XMLWriter): Bunp vtk.js version to fix crash when using XMLWriter a1df59e
Collaborator
|
🎉 This PR is included in version 1.15.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
Yes it's not ideal at all. But for now this was the path of least resistance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting "Uncaught TypeError: pako__WEBPACK_IMPORTED_MODULE_1__.default.deflate is not a function" when attempting to use XMLWriter. Bumping should fix this.