Finish making all the examples use best practice#8
Merged
Conversation
This was referenced May 5, 2026
Merged
jourdain
reviewed
May 7, 2026
| classes="pa-0 fill-height", | ||
| ): | ||
| html_view = vtk.VtkLocalView(renderWindow) | ||
| self.ctrl.on_server_ready.add(html_view.update) |
Collaborator
There was a problem hiding this comment.
that line is not needed anymore. (self.ctrl.on_server_ready.add)
Contributor
Author
There was a problem hiding this comment.
Line removed in
- trame-tutorial: 275860f
- trame docs tutorial: Kitware/trame@d245e67
Contributor
Author
There was a problem hiding this comment.
This is addressed in
jourdain
reviewed
May 7, 2026
Collaborator
|
merging as it is already great. My comments are just to make it even better. Can be done later on. |
UlysseDurand
added a commit
to UlysseDurand/trame-tutorial
that referenced
this pull request
May 11, 2026
UlysseDurand
added a commit
to UlysseDurand/trame
that referenced
this pull request
May 11, 2026
UlysseDurand
added a commit
to UlysseDurand/trame-tutorial
that referenced
this pull request
May 11, 2026
UlysseDurand
added a commit
to UlysseDurand/trame
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finishes the change of all the examples from the tutorial, using TrameApp, the @change decorator, self.ui instead of layout, etc...
The following PR on the trame repo integrates these changes in the doc: Kitware/trame#877