Derive Debug#5
Merged
Merged
Conversation
In consuming the library at the PayJoin crate, Url not deriving Debug caused compilation issues.
Contributor
Author
|
Please consider merging change. It is necessary for payjoin: We need to in order to parse in payjoin params |
Kixunil
approved these changes
Jul 31, 2022
Owner
Kixunil
left a comment
Kixunil
left a comment
There was a problem hiding this comment.
Thanks! It'd be better to impl Param manually and nicer but this is acceptable for now.
Contributor
Author
|
I'm now seeing you asked for this here |
DanGould
added a commit
to DanGould/bip21
that referenced
this pull request
Dec 2, 2024
Replace is_some_and with map_or for MSRV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In consuming the library at the PayJoin crate, Url not deriving Debug caused compilation issues in a complete example at unwraps