Skip to content

Conversation

@Klaster1
Copy link
Owner

@Klaster1 Klaster1 commented Apr 20, 2025

Fix for #38

@Klaster1 Klaster1 requested a review from Copilot April 20, 2025 13:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the issue where the "Create task" button overlaps the "Start task" button in single pane layout. Key changes include:

  • Moving the "Create task" button from one conditional block to a new position after the cdk-virtual-scroll-viewport.
  • Adding an end-to-end test that verifies the layout via visual regression when the window is resized.

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

File Description
src/app/screen-tasks/screen-tasks.component.html Repositions the "Create task" button to resolve layout overlapping.
e2e/fixtures/tasks.ts Introduces an e2e visual regression test for single pane layout.
Files not reviewed (2)
  • src/app/screen-task/screen-task.component.scss: Language not supported
  • src/app/screen-tasks/screen-tasks.component.scss: Language not supported
Comments suppressed due to low confidence (2)

src/app/screen-tasks/screen-tasks.component.html:57

  • The repositioned 'Create task' button is now placed immediately after the virtual scroll viewport. Please ensure that this change does not affect the expected stacking context or interfere with any layout or styling inheritance that might be relied upon elsewhere.
<button

e2e/fixtures/tasks.ts:118

  • The new e2e test resizes the window to trigger the single panel layout; verify that these dimensions reliably produce the intended layout across various environments and screen configurations.
await t.resizeWindow(800, 800);

@Klaster1 Klaster1 marked this pull request as ready for review April 20, 2025 14:25
@Klaster1 Klaster1 merged commit 52fe070 into master Apr 20, 2025
1 check passed
@Klaster1 Klaster1 changed the title Fix "Create task" button showing over "Start task" button when in single pane layout. Fix "Create task" button showing over "Start task" button when in single pane layout #38 Apr 20, 2025
@Klaster1 Klaster1 deleted the issue-38 branch April 20, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants