Treat only & as the urlencoded field separator#290
Merged
Conversation
Per the WHATWG URL standard, application/x-www-form-urlencoded bodies delimit fields with `&` only. `;` is now ordinary data, matching urllib.parse, browsers, httpx, requests, and reqwest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuerystringParsertreated both∧as field separators, falling back to a;scan whenever no&was found. This aligns it with the WHATWG URL standard, under whichapplication/x-www-form-urlencodedbodies are delimited by&only.;is now ordinary field data. This matches every common encoder -urllib.parse, browserURLSearchParams, httpx, requests, and Rust'sserde_urlencoded/reqwest all emit&-separated bodies and none produce;-separated forms - so no conformant client is affected.Collapsing the two-step
find("&") -> find(";")lookup into a single&search also makes parsing linear in the body length rather than quadratic for;-heavy inputs, and the search is now bounded by the truncatedlengthsomax_sizeis respected within a chunk.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.