Validate Content-Length is non-negative in parse_form#297
Merged
Conversation
A negative `Content-Length` (e.g. `-1`) was parsed without sign validation, so `min(content_length - bytes_read, chunk_size)` became negative and `input_stream.read(-1)` drained the whole stream into memory at once, bypassing the chunked-read limit (GHSA-v9pg-7xvm-68hf).
Kludex
changed the title
Content-Length in parse_form
Kludex
changed the title
Content-Length in parse_form
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_form()parsed theContent-Lengthheader into an int without checking its sign. A negative value made the bounded chunked readmin(content_length - bytes_read, chunk_size)go negative, soinput_stream.read(-1)read the whole stream in one call instead of in chunks. This adds a guard rejecting negativeContent-Length, mirroring the existingchunk_sizevalidation a few lines below.Test
Added
test_parse_form_negative_content_length; full suite passes (150 tests).AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.