Preserve depletion Sidak correction behavior#7
Merged
fra-pcmgf merged 2 commits intoKlugerLab:mainfrom Mar 26, 2026
Merged
Conversation
Collaborator
|
I updated the test result. I'm merging the code to main and release a new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This preserves edge-case Sidak correction behavior in the depletion test with the behavior in the original
locat_condensed.py.In
locat-0.1,logsidak_from_logp()returned the unadjustedlogp_minwheneverlogp_min <= 0, which is the ordinary case for log-p values. That effectively skipped the Sidak correction in the depletion scan.This change restores the original behavior from
locat_condensed.py:m_eff <= 1)Why
On local comparison runs, this minimal helper fix was sufficient to bring the
locat-0.1depletion behavior much closer to the originallocat_condensedresults in the null-calibration simulation, without changing the rest of thelocat-0.1scan path.Scope
This PR only changes
logsidak_from_logp()inlocat/locat.py.