Create Accont index to optimize queries on list endpoint#12
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request improves database query performance by adding a compound index to the Account schema and enhances security by updating the MongoDB URI placeholders in configuration.
- Updated the MongoDB URI to replace hardcoded credentials with placeholders.
- Added a compound index in the Account model on name, balance, and createdAt fields.
Files not reviewed (1)
- .env.example: Language not supported
Comments suppressed due to low confidence (1)
src/models/Account.ts:35
- [nitpick] Verify that the descending order for the 'createdAt' field (-1) aligns with the query patterns. If queries require ascending order, update the index accordingly.
accountSchema.index({ name: 1, balance: 1, createdAt: -1 });
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the security of environment variables and enhance the performance of database queries. The most important changes include updating the MongoDB URI to use placeholders for sensitive information and adding an index to the
Accountschema to optimize query performance.Security improvements:
.env.example: Updated theMONGODB_URIto use placeholders for the username and password to avoid hardcoding sensitive information.Database performance enhancements:
src/models/Account.ts: Added an index to theAccountschema to improve the performance of queries involving thename,balance, andcreatedAtfields.