Conversation
…n-any-programming-language.md Add user_seat param
…n-any-programming-language.md Fix broken indentation
…n-any-programming-language.md Add KNAPSACK_PRO_USER_SEAT
…UILD_CREATOR to installation guides
shadre
reviewed
May 4, 2023
| - If no value is detected then a `git rev-parse --abbrev-ref HEAD` command should be run to determine the branch name. | ||
| - If `git` is not installed then raise an error. Please see the [source code of `@knapsack-pro/core`](https://github.com/KnapsackPro/knapsack-pro-core-js/blob/0f44c6a3daa369cd4353e315abbf5539295289ea/src/config/knapsack-pro-env.config.ts#L147,L184). | ||
|
|
||
| - `KNAPSACK_PRO_USER_SEAT` - SHA-256 hash of the user name that started the CI build. Often it's the same person that created the git commit. |
Member
There was a problem hiding this comment.
I would rephrase the 2nd sentence to "It is usually the same person that made the git commit."
shadre
approved these changes
May 4, 2023
Member
shadre
left a comment
shadre
left a comment
There was a problem hiding this comment.
added ideas for copy improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
related