Skip to content

Update Regular Mode API docs, add an attempt to read from the cache#94

Merged
ArturT merged 2 commits intomainfrom
attempt-to-read-from-cache-for-regular-mode
Dec 9, 2022
Merged

Update Regular Mode API docs, add an attempt to read from the cache#94
ArturT merged 2 commits intomainfrom
attempt-to-read-from-cache-for-regular-mode

Conversation

@ArturT
Copy link
Copy Markdown
Member

@ArturT ArturT commented Nov 23, 2022

@ArturT ArturT mentioned this pull request Nov 23, 2022
Merged
@ArturT ArturT requested a review from shadre November 23, 2022 23:09
@3v0k4
Copy link
Copy Markdown
Contributor

3v0k4 commented Dec 5, 2022 •
edited
Loading

@ArturT

I switched to using main as the default branch. gh-pages is where the new GitHub Action deploys/publishes the built site. Please make sure you merge to main, not gh-pages.

I'll document as soon as I can.

@ArturT ArturT changed the base branch from gh-pages to main December 5, 2022 12:35
@ArturT
Copy link
Copy Markdown
Member Author

ArturT commented Dec 5, 2022

@3v0k4 Thanks. I've updated the base branch to main.

@ArturT
Copy link
Copy Markdown
Member Author

ArturT commented Dec 8, 2022

@shadre This PR is also ready for a 2nd code review. Thanks.

@ArturT ArturT merged commit 9cf1d3d into main Dec 9, 2022
@ArturT ArturT deleted the attempt-to-read-from-cache-for-regular-mode branch December 9, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shadre shadre shadre approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArturT @3v0k4 @shadre