Add support for Spinach#41
Merged
ArturT merged 4 commits intoKnapsackPro:masterfrom Jun 3, 2016
ayufan:master
Merged
Conversation
Member
|
@ayufan Great work. Thank you! |
Contributor
Author
|
@ArturT Will you release a new version of gem? :) |
Member
|
@ayufan Yes. I'm on it. I need to do a few small changes and I will let you know. |
Member
|
@ayufan I've just released knapsack 1.11.0. :) |
| @@ -0,0 +1,42 @@ | |||
| require 'spinach' | |||
Member
There was a problem hiding this comment.
@ayufan I found out this causes problems when someone don't use spinach. I did fix in knapsack 1.11.1
https://github.com/ArturT/knapsack/blob/master/CHANGELOG.md#1111
Contributor
Author
There was a problem hiding this comment.
Thanks :) I appreciate it 👍
Member
|
@ayufan I added Spinach support also to knapsack_pro gem. Maybe you would like to try it, it's free? I'd love to hear your feedback. http://knapsackpro.com You have a big project so it might be interesting how the knapsack_pro will work for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for Spinach: https://github.com/codegram/spinach
This MR covers:
spinach_examplesto run test on Travis-CI,