Fail gracefully when there's no git

[ngan]

We're seeing this in our log after upgrading to 5.2.0:

Our codebase doesn't have git during running specs. Is there a way for us to give this information to knapsack? Maybe env variable?

[ArturT]

Thanks for reporting this. I'll raise this with our team.

Is this stopping you from running tests?

We expected the command to fail quietly in case there is no git on the CI.

[ArturT]

@ngan Is clone of the repository inside of the CI at different location?
@3v0k4 If so we could provide a location of the repo with -C like we did here:

knapsack_pro-ruby/lib/knapsack_pro/repository_adapters/git_adapter.rb

Line 56 in e1b301d

dir = KnapsackPro::Config::Env.project_dir

knapsack_pro-ruby/lib/knapsack_pro/repository_adapters/git_adapter.rb

Line 5 in e1b301d

`git -C "#{working_dir}" rev-parse HEAD`.strip

The error looks like git is installed on the CI but is not executed inside of the repository.

[ngan]

We tar up our code to distribute across hundreds of agents. We exclude the .git directory purposefully to reduce space and time to download.

[3v0k4]

Thanks for the report @ngan.

It looks like git prints to stderr but the tests are run properly, correct? Is this a blocker for you?

[ngan]

Yup

[ArturT]

@ngan Please help us understand how urgent this is.

1. Is this causing your tests to fail?
2. If so, can you use the older knapsack_pro gem version for a while?

[ngan]

It’s not urgent. It just doesn’t look good.

[3v0k4]

@ngan please bundle update knapsack_pro to >=5.3.2 and let me know if it fixes the problem.