Skip to content

Slow test analysis runs even when there's no slow tests #224

@ngan

Description

@ngan

We don't always build every single test but it looks like the slow test analysis always runs even when there's no slow test:
https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/lib/knapsack_pro/base_allocator_builder.rb#L55

No slow tests being that slow_test_files = get_slow_test_files is an empty array.

An optimization to make would be to see if we actually got any slow tests back from the get_slow_test_files call. If we got an empty array, it should just bypass the analysis completely.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions