Skip to content

Pass non zero exit status from Cucumber as exit status for Cucumber executed in Queue Mode #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArturT merged 2 commits into from
Mar 6, 2020
Merged

Pass non zero exit status from Cucumber as exit status for Cucumber executed in Queue Mode #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d79d018
Pass non zero exit status from Cucumber as exit status for Cucumber e…
ArturT Mar 6, 2020
41cddd5
Update CHANGELOG.md
ArturT Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change Log

### 1.18.1

* Pass non zero exit status from Cucumber as exit status for Cucumber executed in Queue Mode

https://github.com/KnapsackPro/knapsack_pro-ruby/pull/101

https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v1.18.0...v1.18.1

### 1.18.0

* __IMPORTANT__ Do not allow Fallback Mode when the CI node was retried to avoid running the wrong set of tests
Expand Down
2 changes: 1 addition & 1 deletion lib/knapsack_pro/runners/queue/cucumber_runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def self.run_tests(accumulator)
all_test_file_paths += test_file_paths

result_exitstatus = cucumber_run(runner, test_file_paths, args)
exitstatus = 1 if result_exitstatus != 0
exitstatus = result_exitstatus if result_exitstatus != 0

# KnapsackPro::Hooks::Queue.call_after_subset_queue
# KnapsackPro::Report.save_subset_queue_to_file
Expand Down