Conversation
e6f7e0c to
bb2da51
Compare
ArturT
reviewed
May 2, 2020
ArturT
reviewed
May 2, 2020
ArturT
reviewed
May 2, 2020
ArturT
reviewed
May 2, 2020
Member
|
We can add some context in the description of this PR like. This can be useful if someone will check this PR to understand why we did the change. |
bb2da51 to
f5c85fa
Compare
ArturT
reviewed
May 2, 2020
f5c85fa to
deeae6f
Compare
ArturT
reviewed
May 2, 2020
…'t finish execution
deeae6f to
9d00b2d
Compare
ArturT
approved these changes
May 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes Cucumber in Queue Mode could be killed by CI server for some reason (like exceeding the memory).
We want to make sure the user gets meaningful error as to what happened (and be double sure that killing the process never results in a false positive).
Fix
We raise exception when Cucumber process in Queue Mode failed to execute properly (never exited on its own).