Skip to content

Raise error from Cucumber Queue Mode runner when system process doesn't finish execution#111

Merged
shadre merged 1 commit intomasterfrom
raise-meaningful-error-when-cucumber-process-execution-fails
May 2, 2020
Merged

Raise error from Cucumber Queue Mode runner when system process doesn't finish execution#111
shadre merged 1 commit intomasterfrom
raise-meaningful-error-when-cucumber-process-execution-fails

Conversation

@shadre
Copy link
Copy Markdown
Member

@shadre shadre commented May 2, 2020

Problem

Sometimes Cucumber in Queue Mode could be killed by CI server for some reason (like exceeding the memory).
We want to make sure the user gets meaningful error as to what happened (and be double sure that killing the process never results in a false positive).

Fix

We raise exception when Cucumber process in Queue Mode failed to execute properly (never exited on its own).

@shadre shadre force-pushed the raise-meaningful-error-when-cucumber-process-execution-fails branch from e6f7e0c to bb2da51 Compare May 2, 2020 11:49
@shadre shadre changed the title wip Raise error from Cucumber Queue Mode runner when system process doesn't finish execution May 2, 2020
@shadre shadre requested a review from ArturT May 2, 2020 12:09
Comment thread lib/knapsack_pro/runners/queue/cucumber_runner.rb Outdated
Comment thread lib/knapsack_pro/runners/queue/cucumber_runner.rb Outdated
Comment thread spec/knapsack_pro/runners/queue/cucumber_runner_spec.rb
Comment thread spec/knapsack_pro/runners/queue/cucumber_runner_spec.rb Outdated
@ArturT
Copy link
Copy Markdown
Member

ArturT commented May 2, 2020

We can add some context in the description of this PR like. This can be useful if someone will check this PR to understand why we did the change.

# Problem

example edge case when Cucumber can be killed by CI. Explain that this could lead to situation that tests was green but never run due to Cucumber process killed.

# Fix

We raise exception when Cucumber process was killed.

@shadre shadre force-pushed the raise-meaningful-error-when-cucumber-process-execution-fails branch from bb2da51 to f5c85fa Compare May 2, 2020 13:12
Comment thread CHANGELOG.md Outdated
@shadre shadre force-pushed the raise-meaningful-error-when-cucumber-process-execution-fails branch from f5c85fa to deeae6f Compare May 2, 2020 13:16
Comment thread CHANGELOG.md Outdated
@shadre shadre force-pushed the raise-meaningful-error-when-cucumber-process-execution-fails branch from deeae6f to 9d00b2d Compare May 2, 2020 13:25
@shadre shadre merged commit 036cf8b into master May 2, 2020
@shadre shadre deleted the raise-meaningful-error-when-cucumber-process-execution-fails branch May 2, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants