Conversation
…@before_queue_store to avoid bug with self calling setter and adding nil to array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow defining multiple times hooks for Queue Mode like
KnapsackPro::Hooks::Queue.before_queueKnapsackPro::Hooks::Queue.after_subset_queueKnapsackPro::Hooks::Queue.after_queuewhy
So far you could define only once a hook for Queue Mode. This might be less convenient when you would like to keep hooks related code in a few separate files.
change
You can now define multiple times the same hook. Example:
This works similarly to hooks in RSpec so you can define them many times.
Here are examples of using all hooks in Queue Mode:
https://github.com/KnapsackPro/knapsack_pro-ruby#what-hooks-are-supported-in-queue-mode