Conversation
…g of RSpec split by examples test files (because it's needed to run tests on all parallel nodes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug
remove lazy loading of test files from disk and lazy generating of RSpec split by examples JSON report because the JSON report is needed on all parallel CI nodes to run tests properly when you use RSpec split by test examples feature.
About the bug
The bug was revealed in this CI build
https://app.circleci.com/pipelines/github/KnapsackPro/rails-app-with-knapsack_pro/83/workflows/ccfc0b61-65ca-4e8f-87d5-4e2f0ebcda90/jobs/1377/parallel-runs/0?filterBy=ALL
When CI node did not generate JSON report with test example ids for slow test files (because it connected to existing Queue on API side) then you can't run tests.
Related PR
This PR introduced bug: #133