Verify test runner adapter bind method is called to track test files time execution and ensure tmp/knapsack_pro directory is not removed accidentally by ArturT · Pull Request #137 · KnapsackPro/knapsack_pro-ruby

ArturT · 2021-01-02T22:38:47Z

Thanks to this we can automatically detect not properly configured project setup when someone forgot to add bind method like KnapsackPro::Adapters::RSpecAdapter.bind.
Ensure tmp/knapsack_pro directory is not removed accidentally

…time execution

…_method_called was called

…d. Thanks to that when bind method not called in Queue Mode for Cucumber then exit code will be 1. If we would raise exception than this wouldn't change exit code in case of Cucumber (this was bug)

…sts in parallel on single machine with the same disk (i.e. when using parallel_tests gem)

…s at the same time on the common disk space

Verify test runner adapter bind method is called to track test files …

c35af5d

…time execution

ArturT added the enhancement label Jan 2, 2021

ArturT added 6 commits January 2, 2021 23:43

Update rspec_runner_spec.rb

6a56e11

verify bind method called for queue mode in RSpec

ee690ec

Show 2 reasons why tests could not be recorded properly

90351bf

fix typo

f9d0d93

Extract TMP_DIR

a230079

Use TMP_DIR in other code places

3a82134

ArturT changed the title ~~Verify test runner adapter bind method is called to track test files time execution~~ Verify test runner adapter bind method is called to track test files time execution and ensure tmp/knapsack_pro directory is not removed accidentally Jan 4, 2021

ArturT added 17 commits January 4, 2021 15:02

Update CHANGELOG.md

9838fa6

Update CHANGELOG.md

ed28c7e

Update base_adapter.rb

c63dc92

verify_bind_method_called for regular mode in cucumber

d7bbfe9

Add spec to ensure KnapsackPro::Adapters::CucumberAdapter.verify_bind…

432c7a0

…_method_called was called

Update base_adapter_spec.rb

6be6381

Add spec for verify_bind_method_called

1507859

Explicitly exit process with 1 exit code when bind method not verifie…

7e231ce

…d. Thanks to that when bind method not called in Queue Mode for Cucumber then exit code will be 1. If we would raise exception than this wouldn't change exit code in case of Cucumber (this was bug)

Print new lines to separate error from other messages

9ed8e16

verify bind method called in regular mode for Minitest

65a2f4a

Update cucumber_runner_spec.rb

532be3d

verify bind method called for minitest in queue mode

500f60c

verify bind method called for Test::Unit in regular mode

d3be702

verify bind method called for spinach in regular mode

065d87f

Update base_adapter.rb

f9623d0

add node index to adapter bind method called file to allow running te…

f956fe9

…sts in parallel on single machine with the same disk (i.e. when using parallel_tests gem)

Use adapter class name in file to allow running different test runner…

7b04810

…s at the same time on the common disk space

ArturT merged commit 4320d34 into master Jan 4, 2021

ArturT deleted the verify-bind-method-called branch January 4, 2021 19:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Verify test runner adapter bind method is called to track test files time execution and ensure tmp/knapsack_pro directory is not removed accidentally#137

Verify test runner adapter bind method is called to track test files time execution and ensure tmp/knapsack_pro directory is not removed accidentally#137
ArturT merged 24 commits intomasterfrom
verify-bind-method-called

ArturT commented Jan 2, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ArturT commented Jan 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ArturT commented Jan 2, 2021 •

edited

Loading