Extract links and point them at kspro.com/perma/*#187
Merged
Conversation
e487def to
1f4305a
Compare
3v0k4
commented
Feb 24, 2023
8fcecb4 to
e99b78f
Compare
ArturT
reviewed
Feb 24, 2023
Member
ArturT
left a comment
There was a problem hiding this comment.
It looks good.
I added comments for the PR on the API side that could impact the links here.
5e0cbd2 to
3c676f9
Compare
This was referenced Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding links in the gem, we can use permalinks that perform a 302 redirect, which we can update without requiring anybody to update the gem (and can be tracked if needed).
Example:
Inspiration
explained)rustc --explain E0001