Skip to content

Extract links and point them at kspro.com/perma/*#187

Merged
3v0k4 merged 1 commit intomasterfrom
extract-links
Feb 28, 2023
Merged

Extract links and point them at kspro.com/perma/*#187
3v0k4 merged 1 commit intomasterfrom
extract-links

Conversation

@3v0k4
Copy link
Copy Markdown
Contributor

@3v0k4 3v0k4 commented Feb 23, 2023

Instead of hardcoding links in the gem, we can use permalinks that perform a 302 redirect, which we can update without requiring anybody to update the gem (and can be tracked if needed).

Example:

Inspiration

@3v0k4 3v0k4 self-assigned this Feb 23, 2023
@3v0k4 3v0k4 force-pushed the extract-links branch 2 times, most recently from e487def to 1f4305a Compare February 24, 2023 16:05
Comment thread spec/integration/urls_spec.rb Outdated
@3v0k4 3v0k4 changed the title 🚧 WIP: Extract links Extract links and point them at kspro.com/perma/* Feb 24, 2023
@3v0k4 3v0k4 marked this pull request as ready for review February 24, 2023 16:13
@3v0k4 3v0k4 requested a review from ArturT February 24, 2023 16:14
@3v0k4 3v0k4 force-pushed the extract-links branch 2 times, most recently from 8fcecb4 to e99b78f Compare February 24, 2023 17:38
Copy link
Copy Markdown
Member

@ArturT ArturT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

I added comments for the PR on the API side that could impact the links here.

@3v0k4 3v0k4 force-pushed the extract-links branch 3 times, most recently from 5e0cbd2 to 3c676f9 Compare February 28, 2023 15:05
@3v0k4 3v0k4 merged commit 875c99f into master Feb 28, 2023
@3v0k4 3v0k4 deleted the extract-links branch February 28, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants