[breaking change] KNAPSACK_PRO_CI_NODE_BUILD_ID required#195
Merged
Conversation
3v0k4
changed the title
3v0k4
force-pushed
the
ci-node-build-id-required
branch
from
d15f744 to
55cc790
Compare
ArturT
reviewed
May 18, 2023
ArturT
reviewed
May 18, 2023
| ENV[env_name] || | ||
| ci_env_for(:node_build_id) || | ||
| 'missing-build-id' | ||
| raise("Missing environment variable #{env_name}. Read more at #{KnapsackPro::Urls::KNAPSACK_PRO_CI_NODE_BUILD_ID}") |
Member
There was a problem hiding this comment.
You could update CHANGLELOG as part of this PR. Please also make sure you release a major version 4.0.0 because we have a breaking change here. If someone uses CI provider without out-of-the-box CI build ID support then we could break their CI builds with this change when they upgrade the gem.
ArturT
approved these changes
May 18, 2023
3v0k4
force-pushed
the
ci-node-build-id-required
branch
from
fda0dd6 to
0ad3dbd
Compare
3v0k4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNAPSACK_PRO_CI_NODE_BUILD_IDis a mandatory environment variable, so let's raise when it's missing.Ruby counterpart of KnapsackPro/knapsack-pro-core-js#67