Conversation
ArturT
approved these changes
Jun 6, 2023
| def ci_env_for(env_name) | ||
| value = nil | ||
| ci_list = KnapsackPro::Config::CI.constants - [:Base, :GitlabCI] | ||
| # load GitLab CI first to avoid edge case with order of loading envs for CI_NODE_INDEX |
Member
There was a problem hiding this comment.
Nice that we solve this ugly order workaround for GitLab CI.
| end | ||
|
|
||
| def detected | ||
| ENV['CI_NAME'] == 'codeship' ? self.class : nil |
Member
There was a problem hiding this comment.
This is ok. Should stay as it is. The key CI_NAME does not include the CI provider name so we can't assume what is the CI provider. We need to check the value is codeship.
Co-authored-by: Artur Trzop <arturtrzop@gmail.com>
Co-authored-by: Artur Trzop <arturtrzop@gmail.com>
Co-authored-by: Artur Trzop <arturtrzop@gmail.com>
Co-authored-by: Artur Trzop <arturtrzop@gmail.com>
Co-authored-by: Artur Trzop <arturtrzop@gmail.com>
Co-authored-by: Artur Trzop <arturtrzop@gmail.com>
Co-authored-by: Artur Trzop <arturtrzop@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect CI from environment and get the correct ENVs instead of trying all of them and risk conflicts.
Fixes https://trello.com/c/duyuldsW/76-detect-ci-first-before-reading-the-env-vars