Skip to content

Improve commit authors tracking#209

Merged
3v0k4 merged 3 commits intomasterfrom
authors
Jul 18, 2023
Merged

Improve commit authors tracking#209
3v0k4 merged 3 commits intomasterfrom
authors

Conversation

@3v0k4
Copy link
Copy Markdown
Contributor

@3v0k4 3v0k4 commented Jul 18, 2023 •
edited
Loading

Tested on:

  • CircleCI
  • Buildkite
    • this worked also with the previous code
  • Github Actions
    • this did not work with the previous code

More info on the fix: https://stackoverflow.com/questions/73085141/git-shortlog-in-a-github-workflow-for-a-specific-directory

@3v0k4 3v0k4 self-assigned this Jul 18, 2023
@3v0k4 3v0k4 requested a review from ArturT July 18, 2023 10:06
@3v0k4 3v0k4 marked this pull request as ready for review July 18, 2023 10:06
ArturT
ArturT reviewed Jul 18, 2023
View reviewed changes
Comment thread lib/knapsack_pro/repository_adapters/git_adapter.rb Outdated
ArturT
ArturT reviewed Jul 18, 2023
View reviewed changes
Comment thread lib/knapsack_pro/repository_adapters/git_adapter.rb Outdated
ArturT
ArturT approved these changes Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ArturT ArturT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions on what we could improve.

@ArturT ArturT mentioned this pull request Jul 18, 2023
Merged
@3v0k4 3v0k4 merged commit 12c77c0 into master Jul 18, 2023
@3v0k4 3v0k4 deleted the authors branch July 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArturT ArturT ArturT approved these changes

Assignees

@3v0k4 3v0k4

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@3v0k4 @ArturT