Handle exception when running rspec (Queue mode) #214
Merged
ArturT merged 6 commits intoKnapsackPro:masterfrom Aug 1, 2023
Merged
Handle exception when running rspec (Queue mode) #214ArturT merged 6 commits intoKnapsackPro:masterfrom
ArturT merged 6 commits intoKnapsackPro:masterfrom
Conversation
Member
|
Thanks for the PR, @thukim Could you resolve the conflicts with the master branch? My PR introduced small changes to the files:
or you can give us access to the PR and we can do it on our own when we will start review for this PR. Thanks. To do it, edit PR and select |
…o-ruby into chore/rspec_exception
Contributor
Author
|
Hi @ArturT , I have resolved conflict and also selected Thanks! |
Member
|
Thanks @thukim |
ArturT
approved these changes
Aug 1, 2023
Member
|
I added some small improvements on top of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When running rspec with the queue mode and having exception, the existing code doesn't trigger the
after_subset_queueandafter_queuehooksThis PR handles exception in the above scenario that:
after_subset_queueandafter_queueAfter that, it will re-raise the exception.
Please let me know if there is anything I need to update/address in this PR. Thank you!