Warn when CI env variables are overwritten#254
Merged
Conversation
3v0k4
reviewed
May 20, 2024
Contributor
3v0k4
left a comment
3v0k4
left a comment
There was a problem hiding this comment.
Nice and tidy. Good job!
Leaving it to you to decide if you want a second round or just address the comments and release.
Pacyfik
force-pushed
the
overwritten-ci-env
branch
3 times, most recently
from
4e28ee4 to
e44c0fc
Compare
2 tasks
Pacyfik
force-pushed
the
overwritten-ci-env
branch
from
e44c0fc to
52194a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
https://trello.com/c/VMKgyjFP/365-warn-when-overriding-envs-in-supported-ci-ruby-js
Related
TODO: links to related PRs or issuesDescription
Log when
KNAPSACK_PRO_*environment variables are set manually if their values could be automatically determined from supported CI environments, and both values are different.Changes
Uses
logger.infoto display a message when both theKNAPSACK_PRO_*and CI envs are present and different from each other.Checklist reminder
lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and e2e tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and e2e tested.