Raise when *_NODE_TOTAL or *_NODE_INDEX is missing#256
Merged
Conversation
Pacyfik
force-pushed
the
raise-when-node-envs-missing
branch
from
1d459ca to
d3d4d74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
https://trello.com/c/jB6bXgzH/192
Description
Raise when
KNAPSACK_PRO_CI_NODE_TOTALorKNAPSACK_PRO_CI_NODE_INDEXis missing and can't be determined from supported CI environments, instead of defaulting to arbitrary numbers.Changes
ci_node_totalno longer defaults to 1 andci_node_indexno longer defaults to 0. Instead, an error is raised, like with missingci_node_build_idortest_suite_token.Checklist reminder
lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and e2e tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and e2e tested.