Conversation
…which means rails_helper is not loaded and knapsack_pro lib is also not loaded. This verifies if the custom KnapsackPro::Formatters::TimeTracker formatter from knapsack_pro can be used before knapsack_pro is loaded #263
…en the .rspec file is not loaded with --require spec_helper
Member
Author
|
Without this line 3eba3fa the CI build fails now. We are able to detect problems with I tried to reproduce the issue in Queue Mode but it occurs only in Regular Mode so I added integration test in CI pipeline for regular mode only. |
Pacyfik
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
link to the internal story
Related
Description
Fix an error for the
KnapsackPro::Formatters::TimeTrackerformatter in RSpec when using Knapsack Pro Regular Mode and the.rspecfile is not present.Add a test on CI to reproduce the error. It ensures the bug won't happen again.
Checklist reminder
UNRELEASEDsection of theCHANGELOG.md, including the needed bump (ie, patch, minor, major)lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and e2e tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and e2e tested.