Skip to content

fix: handle nil backtrace#272

Merged
3v0k4 merged 1 commit intomasterfrom
backtrace
Oct 8, 2024
Merged

fix: handle nil backtrace#272
3v0k4 merged 1 commit intomasterfrom
backtrace

Conversation

@3v0k4
Copy link
Copy Markdown
Contributor

@3v0k4 3v0k4 commented Oct 8, 2024

Description

#backtrace could be nil in:

Better to look at the c source as the docs may not be always clear on what the return values are (as in this case).

I don't think we need additional test coverage because we are not dealing with a bug that could cause a regression.

Checklist reminder

  • You added the changes to the UNRELEASED section of the CHANGELOG.md, including the needed bump (ie, patch, minor, major)
  • You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
    • Pure: lib/knapsack_pro/pure/queue/rspec_pure.rb contains pure functions that are unit tested.
    • Extension: lib/knapsack_pro/extensions/rspec_extension.rb encapsulates calls to RSpec internals and is integration and e2e tested.
    • Runner: lib/knapsack_pro/runners/queue/rspec_runner.rb invokes the pure code and the extension to produce side effects, which are integration and e2e tested.

@3v0k4 3v0k4 self-assigned this Oct 8, 2024
@3v0k4 3v0k4 merged commit 5e5da97 into master Oct 8, 2024
@3v0k4 3v0k4 deleted the backtrace branch October 8, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants