Skip to content

Set RSpec.world.wants_to_quit to true when any signal is received by the knapsack_pro gem to allow graceful exit #273

Merged
ArturT merged 3 commits intomasterfrom
fix-int
Oct 10, 2024
Merged

Set RSpec.world.wants_to_quit to true when any signal is received by the knapsack_pro gem to allow graceful exit #273
ArturT merged 3 commits intomasterfrom
fix-int

Conversation

@ArturT
Copy link
Copy Markdown
Member

@ArturT ArturT commented Oct 9, 2024

Story

TODO: N/A

Related

Description

Set RSpec.world.wants_to_quit to true when any signal is received by the knapsack_pro gem. This allows RSpec to gracefully exit as soon as the signal is received, instead of waiting for the test file to finish running.

This also ensures that external libraries, like datadog-ci, behave properly when RSpec is quitting.

Checklist reminder

  • You added the changes to the UNRELEASED section of the CHANGELOG.md, including the needed bump (ie, patch, minor, major)
  • You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
    • Pure: lib/knapsack_pro/pure/queue/rspec_pure.rb contains pure functions that are unit tested.
    • Extension: lib/knapsack_pro/extensions/rspec_extension.rb encapsulates calls to RSpec internals and is integration and e2e tested.
    • Runner: lib/knapsack_pro/runners/queue/rspec_runner.rb invokes the pure code and the extension to produce side effects, which are integration and e2e tested.

@ArturT ArturT added the bug label Oct 9, 2024
@ArturT ArturT merged commit 47974e2 into master Oct 10, 2024
@ArturT ArturT deleted the fix-int branch October 10, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants