Skip to content

improvement(RSpec): use test file execution times for existing test files on the disk to determine slow test files. This fixes issue with detecting slow test files when API token is shared between multiple test suites.#277

Merged
ArturT merged 2 commits intomasterfrom
fix-slow-test-files-detection
Oct 29, 2024

Conversation

@ArturT
Copy link
Copy Markdown
Member

@ArturT ArturT commented Oct 29, 2024

Story

TODO: link to the internal story

Description

Related to the RSpec split by examples feature and when someone uses the same API token for multiple test suites.
https://docs.knapsackpro.com/ruby/split-by-test-examples/

Changes

Use test file execution times for existing test files on disk to identify slow test files.

This fixes an issue with detecting slow test files when the API token is shared between multiple test suites.

Related to PR:

Checklist reminder

  • You added the changes to the UNRELEASED section of the CHANGELOG.md, including the needed bump (ie, patch, minor, major)
  • You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
    • Pure: lib/knapsack_pro/pure/queue/rspec_pure.rb contains pure functions that are unit tested.
    • Extension: lib/knapsack_pro/extensions/rspec_extension.rb encapsulates calls to RSpec internals and is integration and e2e tested.
    • Runner: lib/knapsack_pro/runners/queue/rspec_runner.rb invokes the pure code and the extension to produce side effects, which are integration and e2e tested.

…sk to determine slow test files

This fixes issue with detecting slow test files when API token is shared between multiple test suites.

Related to PR: #276
@ArturT ArturT added the RSpec label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant