Skip to content

RSpec: Use the same regex#291

Merged
3v0k4 merged 1 commit intomasterfrom
regex
Mar 11, 2025
Merged

RSpec: Use the same regex#291
3v0k4 merged 1 commit intomasterfrom
regex

Conversation

@3v0k4
Copy link
Copy Markdown
Contributor

@3v0k4 3v0k4 commented Mar 11, 2025

Description

In the RSpec code, the regex is different than the one in the Rubular link.

Let's use the regex from the source code for both cases.

Checklist reminder

  • You added the changes to the UNRELEASED section of the CHANGELOG.md, including the needed bump (ie, patch, minor, major)
  • You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
    • Pure: lib/knapsack_pro/pure/queue/rspec_pure.rb contains pure functions that are unit tested.
    • Extension: lib/knapsack_pro/extensions/rspec_extension.rb encapsulates calls to RSpec internals and is integration and e2e tested.
    • Runner: lib/knapsack_pro/runners/queue/rspec_runner.rb invokes the pure code and the extension to produce side effects, which are integration and e2e tested.

@3v0k4 3v0k4 merged commit 04d8fde into master Mar 11, 2025
45 checks passed
@3v0k4 3v0k4 deleted the regex branch March 11, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants