Skip to content

Revert 8.2.0 version change#302

Merged
ArturT merged 8 commits intomainfrom
revert-8.2
May 29, 2025
Merged

Revert 8.2.0 version change#302
ArturT merged 8 commits intomainfrom
revert-8.2

Conversation

@ArturT
Copy link
Copy Markdown
Member

@ArturT ArturT commented May 29, 2025

Story

https://trello.com/c/tEgpIuOn

Description

This PR reverts changes from 8.2.0 version that have been introduced in:

to address the issue reported in:

But we keep some code simplification:

  • Keep Kernel.exec for Spinach to avoid catching the exit code
  • Keep: fd13e84 - we removed the unneeded EXTRA_TEST_FILES_DELAY env var in CircleCI yml that was accidentally added some time ago.

  • You added the changes to the UNRELEASED section of the CHANGELOG.md, including the needed bump (ie, patch, minor, major)
  • You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
    • Pure: lib/knapsack_pro/pure/queue/rspec_pure.rb contains pure functions that are unit tested.
    • Extension: lib/knapsack_pro/extensions/rspec_extension.rb encapsulates calls to RSpec internals and is integration and e2e tested.
    • Runner: lib/knapsack_pro/runners/queue/rspec_runner.rb invokes the pure code and the extension to produce side effects, which are integration and e2e tested.

Comment thread CHANGELOG.md Outdated
ArturT and others added 2 commits May 29, 2025 16:40
Co-authored-by: Riccardo <riccardo.odone@gmail.com>
@ArturT ArturT merged commit cb775ac into main May 29, 2025
25 checks passed
@ArturT ArturT deleted the revert-8.2 branch May 29, 2025 14:51
@ArturT ArturT mentioned this pull request May 29, 2025
@3v0k4 3v0k4 mentioned this pull request May 29, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants