Skip to content

[RSpec] Fix issues in TimeTracker#303

Merged
ArturT merged 1 commit intomainfrom
tt
Jul 2, 2025
Merged

[RSpec] Fix issues in TimeTracker#303
ArturT merged 1 commit intomainfrom
tt

Conversation

@3v0k4
Copy link
Copy Markdown
Contributor

@3v0k4 3v0k4 commented Jun 26, 2025

Story

https://trello.com/c/zrjMajhs/758-support-fix-time-tracker

Description

The time tracker missed some before(:all)/after(:all) that weren't in the top level group.

With this change, the following X gaps are considered before(:all)/after(:all):

describe do
  X (example_started)
  it {}
  X (example_group_started)
  describe do
    X (example_started)
    it {}
    X (example_group_finished)
  end
  X (example_group_started)
  describe do
    X (example_started)
    it {}
  end
  X (example_group_finished)
end

Checklist reminder

  • You added the changes to the UNRELEASED section of the CHANGELOG.md, including the needed bump (ie, patch, minor, major)
  • You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
    • Pure: lib/knapsack_pro/pure/queue/rspec_pure.rb contains pure functions that are unit tested.
    • Extension: lib/knapsack_pro/extensions/rspec_extension.rb encapsulates calls to RSpec internals and is integration and e2e tested.
    • Runner: lib/knapsack_pro/runners/queue/rspec_runner.rb invokes the pure code and the extension to produce side effects, which are integration and e2e tested.

@3v0k4 3v0k4 marked this pull request as ready for review July 2, 2025 13:14
@ArturT ArturT merged commit e67326a into main Jul 2, 2025
25 checks passed
@ArturT ArturT deleted the tt branch July 2, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants