Skip to content

Replace Hash#sum with Hash#reduce to fix a rare bug in the RSpec time tracker for a specific project #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArturT merged 7 commits into from
Jul 25, 2025
Merged

Replace Hash#sum with Hash#reduce to fix a rare bug in the RSpec time tracker for a specific project #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
618debb
log more info from time tracker
ArturT Jul 15, 2025
1ef7789
debugging logs
ArturT Jul 15, 2025
445dfbb
fix: use reduce instead of sum on Hash which can be unpredictable
ArturT Jul 24, 2025
3c45c04
remove puts
ArturT Jul 24, 2025
d2e4d28
Revert "remove puts"
ArturT Jul 24, 2025
b693cec
Reapply "remove puts"
ArturT Jul 25, 2025
ab90512
Update CHANGELOG.md
ArturT Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

### UNRELEASED (patch)

### 8.3.3

* Fix a `Hash#sum` bug in the time tracker for RSpec

https://github.com/KnapsackPro/knapsack_pro-ruby/pull/305

https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v8.3.2...v8.3.3

### 8.3.2

* Fix infinite recursion when the logger enters a loop. [The issue](https://github.com/KnapsackPro/knapsack_pro-ruby/issues/269) occurs when `KNAPSACK_PRO_LOG_DIR=log` is set and a conflict arises between the values of environment variables from the CI provider and those configured by the user (e.g., `KNAPSACK_PRO_CI_NODE_INDEX`, `KNAPSACK_PRO_CI_NODE_TOTAL`).
Expand Down
8 changes: 4 additions & 4 deletions lib/knapsack_pro/formatters/time_tracker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ def add_hooks_time(group, time_all_by_group_id_path)
group.each do |_, example|
next if example[:time_execution] == 0.0

example[:time_execution] += time_all_by_group_id_path.sum do |group_id_path, time|
example[:time_execution] += time_all_by_group_id_path.reduce(0.0) do |sum, (group_id_path, time)|
# :path is a file path (a_spec.rb), sum any before/after(:all) in the file
next time if group_id_path.start_with?(example[:path])
next sum + time if group_id_path.start_with?(example[:path])
# :path is an id path (a_spec.rb[1:1]), sum any before/after(:all) above it
next time if example[:path].start_with?(group_id_path[0..-2])
0
next sum + time if example[:path].start_with?(group_id_path[0..-2])
sum
end
end
end
Expand Down