Add RSpec Queue Formatter to hide duplicated pending and failed tests in Queue Mode#31
Merged
Add RSpec Queue Formatter to hide duplicated pending and failed tests in Queue Mode#31
Conversation
at the end of queue mode run. Hide pending and failed tests for intermediate tests runs after each fetch test files from Knapsack Pro API.
ArturT
changed the title
ArturT
commented
Apr 23, 2017
|
|
||
| if KnapsackPro::Config::Env.modify_default_rspec_formatters? | ||
| class RSpec::Core::Formatters::BaseTextFormatter | ||
| prepend KnapsackPro::Formatters::RSpecHideFailuresAndPendingExtension |
Member
Author
There was a problem hiding this comment.
then we don’t run rspec queue summary formatter
|
Thanks so much for this @ArturT! It's so much better. One thing I'm still noticing is duplicate |
Member
Author
|
@toolmantim I did fix for Please update knapsack_pro to the newest version. ;) Tech note: |
|
Amazing! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNAPSACK_PRO_MODIFY_DEFAULT_RSPEC_FORMATTERSRelated to: rspec/rspec-core#2416