Retry request 3 times when API returns 5xx HTTP status#78
Merged
Conversation
* X-Request-Id is set by Knapsack Pro API rails app * nginx returns 502 when request never touched unicorn due to busy unicorn then X-Request-Id is empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
When API returns 5xx error we don't retry the request.
Because of that, we run tests in Fallback Mode right away when nginx returns 502 error when could not connect to unicorn process on API side.
After this change
Retry request 3 times. If all 3 requests fail then start Fallback Mode.
Thanks to this change during API traffic peak time the Fallback Mode will be started only when it actually needs to.