Skip to content

Logs error on lost info about recorded timing for test files due to missing json files in Queue Mode#83

Merged
ArturT merged 5 commits intomasterfrom
detect-missing-json-files-in-queue-mode
May 2, 2019
Merged

Logs error on lost info about recorded timing for test files due to missing json files in Queue Mode#83
ArturT merged 5 commits intomasterfrom
detect-missing-json-files-in-queue-mode

Conversation

@ArturT
Copy link
Copy Markdown
Member

@ArturT ArturT commented May 1, 2019

Problem is related to knapsack_pro Queue Mode

Sometimes users have in their tests code that clears tmp directory. For instance, user can have RSpec hooks like after(:each) or after(:suite) that remove the content of tmp folder.

knapsack_pro gem uses tmp/knapsack_pro/queue/ directory to store json files with a recorded time of tests.

Introduced change

This pull request adds log error to notify the user when the tmp/knapsack_pro/queue/ directory is empty even when some test files where executed. It means the user has probably RSpec hook or some other code that clears tmp directory which breaks knapsack_pro.

Another reason might be that you forgot to add Knapsack::Adapters::RspecAdapter.bind in your rails_helper.rb or spec_helper.rb. Please follow the installation guide again: https://docs.knapsackpro.com/integration/

@ArturT ArturT changed the title Logs error on lost info about recorded timing for test files due missing json files Logs error on lost info about recorded timing for test files due missing json files in Queue Mode May 1, 2019
@ArturT ArturT changed the title Logs error on lost info about recorded timing for test files due missing json files in Queue Mode Logs error on lost info about recorded timing for test files due to missing json files in Queue Mode May 2, 2019
@ArturT ArturT merged commit 44aa1e9 into master May 2, 2019
@ArturT ArturT deleted the detect-missing-json-files-in-queue-mode branch May 2, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant