Conversation
missing json files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem is related to knapsack_pro Queue Mode
Sometimes users have in their tests code that clears
tmpdirectory. For instance, user can have RSpec hooks likeafter(:each)orafter(:suite)that remove the content oftmpfolder.knapsack_pro gem uses
tmp/knapsack_pro/queue/directory to store json files with a recorded time of tests.Introduced change
This pull request adds log error to notify the user when the
tmp/knapsack_pro/queue/directory is empty even when some test files where executed. It means the user has probably RSpec hook or some other code that clearstmpdirectory which breaks knapsack_pro.Another reason might be that you forgot to add
Knapsack::Adapters::RspecAdapter.bindin yourrails_helper.rborspec_helper.rb. Please follow the installation guide again: https://docs.knapsackpro.com/integration/