Skip to content

Fix GitLab CI environment variables integration#88

Merged
ArturT merged 3 commits intomasterfrom
gitlab-ci
Jul 5, 2019
Merged

Fix GitLab CI environment variables integration#88
ArturT merged 3 commits intomasterfrom
gitlab-ci

Conversation

@ArturT
Copy link
Copy Markdown
Member

@ArturT ArturT commented Jul 5, 2019

  • Use CI_PIPELINE_ID as build ID for GitLab CI because it is unique across parallel jobs
  • Load GitLab CI envs first to avoid edge case with an order of loading envs for CI_NODE_INDEX. Gitlab CI starts from 1 instead of index 0 for CI_NODE_INDEX. We should first check if CI is Gitlab CI then do CI_NODE_INDEX - 1. Otherwise, assume it's other CI provider and just use CI_NODE_INDEX.

@ArturT ArturT added the bug label Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant