Skip to content

Allow to use Queue Mode for old RSpec versions that don't have RSpec.configuration.reset_filters method #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArturT merged 2 commits into from
Jan 25, 2020
Merged

Allow to use Queue Mode for old RSpec versions that don't have RSpec.configuration.reset_filters method #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee69001
Call reset_filters for RSpec only if this method exists. This way we …
ArturT Jan 25, 2020
05e87ed
Update CHANGELOG.md
ArturT Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change Log

### 1.16.1

* Allow to use Queue Mode for old RSpec versions that don't have `RSpec.configuration.reset_filters` method

https://github.com/KnapsackPro/knapsack_pro-ruby/pull/96

https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v1.16.0...v1.16.1

### 1.16.0

* Add test runner name to `KNAPSACK-PRO-CLIENT-NAME` header send to Knapsack Pro API
Expand Down
6 changes: 5 additions & 1 deletion lib/knapsack_pro/runners/queue/rspec_runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,11 @@ def self.rspec_clear_examples
end
RSpec.world.example_groups.clear
RSpec.configuration.start_time = ::RSpec::Core::Time.now
RSpec.configuration.reset_filters

# skip reset filters for old RSpec versions
if RSpec.configuration.respond_to?(:reset_filters)
RSpec.configuration.reset_filters
end
end
end
end
Expand Down