This repository was archived by the owner on Nov 27, 2023. It is now read-only.
fix: gitroot only worked once#483
Merged
KnisterPeter merged 2 commits intoKnisterPeter:masterfrom Apr 16, 2021
Merged
Conversation
added 2 commits
April 15, 2021 15:47
KnisterPeter
approved these changes
Apr 16, 2021
Owner
|
@shipjs prepare |
|
@KnisterPeter |
Owner
|
@solaris765 Thanks for fixing. This is released as v0.14.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git Root was only working once on load since the return statement was moved up.
Fix was to shift the gitroot null check into its own if statement.