Conversation
wookieejedi
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to revert #352 this for the following reasons, though I'd be happy to discuss:
Each time I download a nightly it runs the PowerShell script which requires confirming a popup, but then when running the nightly the Windows firewall pops up regardless (just like it always did). Alas, this seems to just add an extra click unfortunately, and what's more damaging it seems to sporadically trigger Windows to block Knossos. I've had it happen twice now in the past month or so where Windows just outright blocks Knossos, and each time I have to fully reinstall Knossos to get it to work again (I can turn Smart App off ofc, but I'd prefer not to especially since most folks casually using Knossos or TCs especially will very likely just stop playing as opposed to blocking Smart App).
Again happy to discuss but the current method causes those pitfalls while not saving any actual clicks, so I'd reckon reverting is the best bet.