Fix weird nebula log and incorrect success mod upload report on fail + (H8, H9 fix)#369
Merged
Shivansps merged 2 commits intoKnossosNET:mainfrom Apr 10, 2026
Merged
Conversation
wookieejedi
approved these changes
Apr 8, 2026
Shivansps
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the weird api reply logs without a reply
Error : (Nebula.ApiCall(mod/release)) An error has ocurred during nebula api POST call: OK(200)
System.Net.Http.StringContent
the expected getmodid with not found when checking if the mod is already uploaded
Error : (Nebula.GetModJson) Unable to get mod json data. ID: SF_EH Version: 0.8.42 Reason: not_found
and the incorrect UI reporting the mod upload completed successfully when it failed.
4/6/2026 1:17:01 PM - Information : (Nebula.UpdateMod) UpdateMod: Star Fox Event Horizon 0.8.42 OK!
4/6/2026 1:17:18 PM - Error : (Nebula.ApiCall(mod/release)) An error has ocurred during nebula api POST call: OK(200)
System.Net.Http.StringContent
4/6/2026 1:17:18 PM - Error : (Nebula.ReleaseMod) ReleaseMod: Star Fox Event Horizon 0.8.42 error. Reason: archive missing