Skip to content

Fix broken api call during nebula token renewal (C2 fix) #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivansps merged 1 commit into from
Apr 12, 2026
Merged

Fix broken api call during nebula token renewal (C2 fix) #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions Knossos.NET/Models/Nebula.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,12 +736,14 @@ private enum ApiMethod
/// <param name="needsLogIn"></param>
/// <param name="timeoutSeconds"></param>
/// <param name="method"></param>
/// <param name="attempt"></param>
/// <returns>
/// apireply or null if the call failed completely
/// It is difficult to point out exactly what the reply is because it changed from call to call
/// Most api calls return a ApiReply.result true or false if successfull or not but this is not to case for every call
/// If the nebula token is expired, the api call will attempt up to 3 times to renew it.
/// </returns>
private static async Task<ApiReply?> ApiCall(string resourceUrl, HttpContent? data, bool needsLogIn = false, int timeoutSeconds = 45, ApiMethod method = ApiMethod.POST)
private static async Task<ApiReply?> ApiCall(string resourceUrl, HttpContent? data, bool needsLogIn = false, int timeoutSeconds = 45, ApiMethod method = ApiMethod.POST, int attempt = 0)
{
//Custom mode with no nebula services
if (Knossos.inSingleTCMode && !CustomLauncher.UseNebulaServices)
Expand Down Expand Up @@ -775,9 +777,9 @@ private enum ApiMethod
throw new ArgumentNullException(nameof(data));
}
var response = await client.PostAsync(apiURL + resourceUrl, data);
data.Dispose();
if (response.IsSuccessStatusCode)
{
data.Dispose();
var jsonReply = await response.Content.ReadAsStringAsync();
if (jsonReply == "OK") // multiupload/part hack
{
Expand All @@ -799,10 +801,16 @@ private enum ApiMethod
/* Nebula responds with a HTTP status code 401 for expired tokens, so lets try this again */
if(needsLogIn && apiUserToken != null && response.StatusCode == System.Net.HttpStatusCode.Unauthorized)
{
Log.Add(Log.LogSeverity.Information, "Nebula.ApiCall()", "Nebula: User login token is expired.");
apiUserToken = null;
return await ApiCall(resourceUrl, data, needsLogIn, timeoutSeconds, method);
if (attempt <= 3)
{
attempt++;
await Task.Delay(2000);
Log.Add(Log.LogSeverity.Information, "Nebula.ApiCall()", $"Nebula: User login token is expired. Trying to renew #{attempt}");
apiUserToken = null;
return await ApiCall(resourceUrl, data, needsLogIn, timeoutSeconds, method, attempt);
}
}
data.Dispose();
/* Upload/Update/delete Mod Timeout Hack */
if(response.StatusCode.ToString() == "GatewayTimeout" && (resourceUrl == "mod/release" || resourceUrl == "mod/release/update" || resourceUrl == "mod/release/delete"))
{
Expand Down