Make GetFlagsV1 async to avoid blocking the UI thread#396
Merged
Conversation
GetFlagsV1() was called synchronously on the UI thread at startup, when navigating to the Settings tab, and when opening the Configure Flags dialog. This caused a brief UI freeze each time FSO was spawned to read flag data. Also fixes a potential pipe deadlock: the original code read stdout to completion before reading stderr. If FSO wrote more than ~4 KB to stderr the process would block waiting for the pipe to drain, which Knossos would never do until stdout finished -- a classic deadlock. The fix reads both streams concurrently with Task.WhenAll before calling WaitForExitAsync. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Shivansps
approved these changes
May 6, 2026
Contributor
|
Testing and this one works fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetFlagsV1() was called synchronously on the UI thread at startup, when navigating to the Settings tab, and when opening the Configure Flags dialog. This caused a brief UI freeze each time FSO was spawned to read flag data.
Also fixes a potential pipe deadlock: the original code read stdout to completion before reading stderr. If FSO wrote more than ~4 KB to stderr the process would block waiting for the pipe to drain, which Knossos would never do until stdout finished -- a classic deadlock. The fix reads both streams concurrently with Task.WhenAll before calling WaitForExitAsync.